Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Fix link to json example #17766

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

holgerfriedrich
Copy link
Member

Maybe fixes #17418.

Same approach worked for an image in #17175, not sure if it works for other files.
@stefan-hoehn WDYT?

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think that this works. I'll approve and then let's see on https://next.openhab.org/addons/ if it helped. Though we need a @openhab/maintainers to approve this as well.

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Nov 18, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, weird that it is not picked up...

@lsiepel lsiepel merged commit 063f551 into openhab:main Nov 18, 2024
5 checks passed
@holgerfriedrich holgerfriedrich deleted the pr-metrics-docs branch November 18, 2024 22:26
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
weymann pushed a commit to weymann/openhab-addons that referenced this pull request Dec 25, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics service] Broken link to the example Grafana dashboard
3 participants