Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onkyo] Fix audio sink for some receiver models #17770

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

druciak
Copy link
Member

@druciak druciak commented Nov 19, 2024

Fix for Onkyo audio sink on TX-NR646
More details on community thread

Fixes #17755

…hab#17755)

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
@druciak druciak added the bug An unexpected problem or unintended behavior of an add-on label Nov 19, 2024
@druciak druciak requested review from lsiepel and mherwege November 19, 2024 18:54
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, otherwise LGTM

@lsiepel lsiepel removed the request for review from mherwege November 20, 2024 20:42
Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 0901c47 into openhab:main Nov 21, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 21, 2024
@jlaur jlaur changed the title [Onkyo] Set "CurrentURIMetaData" for "SetAVTransportURI" action (#17755) [Onkyo] Fix audio sink for some receiver models Nov 22, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
…hab#17755) (openhab#17770)

* [Onkyo] Set "CurrentURIMetaData" for "SetAVTransportURI" action (openhab#17755)

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[onkyo] Audio sink does not play any sounds on TX-NR646
2 participants