Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linky] Thing goes OFFLINE once again #17774

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

clinique
Copy link
Contributor

Correction of the url.
Resolves #17773

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner November 21, 2024 11:11
@clinique clinique self-assigned this Nov 21, 2024
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Nov 21, 2024
@clinique clinique changed the title [linky] Thing goes OFFLI§NE once again [linky] Thing goes OFFLINE once again Nov 21, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 9df7d58 into openhab:main Nov 21, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Nov 21, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Nov 21, 2024

Does it need a backport?

@clinique
Copy link
Contributor Author

Does it need a backport?

Yes, please.

@lolodomo
Copy link
Contributor

Was the previous PR already backported ?

@lsiepel
Copy link
Contributor

lsiepel commented Nov 21, 2024

Was the previous PR already backported ?

Guess you refer to #17538 i hesitate to backport that one as it is not just the mandatory bug fix, but also has some other changes.

@lolodomo
Copy link
Contributor

Backporting this new one if the other was not backported is I believe fully useless as the binding will still not work.
To be confirmed by @clinique

@clinique
Copy link
Contributor Author

I do confirm. This binding is broken until then. But maybe we're only 3 using it :-)

lsiepel pushed a commit that referenced this pull request Nov 21, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Nov 21, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Nov 21, 2024

Both PR's are now backported.

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linky] Binding again unavailable
3 participants