Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tapocontrol] Improve color temperature channel #17779

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

andrewfg
Copy link
Contributor

See #17754

Signed-off-by: AndrewFG software@whitebear.ch

Signed-off-by: AndrewFG <software@whitebear.ch>
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Nov 21, 2024
@andrewfg andrewfg requested a review from lolodomo November 21, 2024 17:45
@andrewfg andrewfg self-assigned this Nov 21, 2024
@jlaur jlaur changed the title [tapocontrol] Improvements to color temperature channel [tapocontrol] Improve color temperature channel Nov 21, 2024
@lolodomo
Copy link
Contributor

This is fine for me; only the migration of channel item type has to be checked and confirmed as working.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit c758013 into openhab:main Nov 24, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Nov 24, 2024
@andrewfg andrewfg deleted the 17754-tapocontrol branch November 26, 2024 11:58
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: AndrewFG <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants