[oppo] Add missing input option and enable translations #17783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
lolodomo
reviewed
Nov 22, 2024
| @@ -105,10 +114,14 @@ public class OppoHandler extends BaseThingHandler implements OppoMessageEventLis | |||
| * Constructor | |||
| */ | |||
| public OppoHandler(Thing thing, OppoStateDescriptionOptionProvider stateDescriptionProvider, | |||
| SerialPortManager serialPortManager) { | |||
| SerialPortManager serialPortManager, @Reference TranslationProvider translationProvider, | |||
There was a problem hiding this comment.
Do not use @reference here.
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
added
rebuild
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* Add missing input option and enable translations Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
weymann
pushed a commit
to weymann/openhab-addons
that referenced
this pull request
Dec 25, 2024
* Add missing input option and enable translations Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Add missing input option and enable translations Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing
ARC 2option for the Source Input channel of the BDP-103/BDP-105.Also enable translation of all of the various models' selectable option labels.