Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homewizard] Fix NumberFormatException #17792

Merged
merged 3 commits into from
Nov 23, 2024
Merged

[homewizard] Fix NumberFormatException #17792

merged 3 commits into from
Nov 23, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Nov 22, 2024

Fixes: #17758

@lsiepel
Fix exception
e181dbd 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Nov 22, 2024
jlaur
jlaur reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question.

...inding.homewizard/src/main/java/org/openhab/binding/homewizard/internal/dto/DataPayload.java Outdated Show resolved Hide resolved
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Nov 22, 2024
@jlaur
Copy link
Contributor

jlaur commented Nov 22, 2024

Regression of #16995.

@lsiepel
Round instead of truncate
b4ba68e 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but awaiting confirmation if value should be round rather than preserving the precision.

@lsiepel
Review comments
a1143b9 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 23, 2024
@jlaur jlaur merged commit 7ece8ad into openhab:main Nov 23, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Nov 23, 2024
@lsiepel lsiepel deleted the homewizard-decimal branch November 23, 2024 20:33
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@lsiepel @matchews
[homewizard] Fix NumberFormatException (openhab#17792)
1a1144c 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@maniac103 maniac103 maniac103 left review comments

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[homewizard] The p1 meter stays in status unknow
3 participants
@lsiepel @jlaur @maniac103