-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irobot] Update documentation regarding button names #17806
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Thanks! This seems to fix the "small nit" mentioned in the linked issue, but I'm not sure this is fully addressed?
|
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Saving the password was already there, but maybe better to be explicit. While adapting it, i also made some other changes so it would be possible to use links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explicitly mentioning copying the password, only some nit picking left.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
…b-addons into irobot-doc-button Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Fixes: #10388