Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mapdb] Store and restore lastState, lastStateChange and lastChangeUpdate #17820

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

mherwege
Copy link
Contributor

Requires openhab/openhab-core#4463 and openhab/openhab-core#4351

This PR enhances the MapDB persistence service to also store lastState, lastStateUpdate and lastStateChange. It also makes it possible to restore these on startup.

@jimtng FYI

@mherwege mherwege requested a review from a team as a code owner November 29, 2024 17:14
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Nov 29, 2024
@lsiepel lsiepel requested a review from jimtng November 29, 2024 23:02
Copy link
Contributor

@jimtng jimtng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor comment/question.

@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Feb 15, 2025
@kaikreuzer kaikreuzer closed this Feb 15, 2025
@kaikreuzer kaikreuzer reopened this Feb 15, 2025
mherwege and others added 3 commits February 15, 2025 22:10
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member

@mherwege Could you please have a look at the compilation issues? The core bundles should already be updated.

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member

Nevermind, I've fixed it.

@kaikreuzer kaikreuzer merged commit c123341 into openhab:main Feb 16, 2025
2 checks passed
@kaikreuzer kaikreuzer added this to the 5.0 milestone Feb 16, 2025
@mherwege
Copy link
Contributor Author

Nevermind, I've fixed it.

Thanks for the help.

@mherwege mherwege deleted the mapdb_lastState branch February 16, 2025 13:06
matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
…date (openhab#17820)

* persist and restore previous state and last state change

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants