Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsmr] Fix IllegalStateException in rfc2217 connector #17854

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Dec 6, 2024

Fixes: #15529

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Dec 6, 2024
@lsiepel lsiepel requested a review from Hilbrand as a code owner December 6, 2024 10:24
@lolodomo lolodomo added the rebuild Triggers Jenkins PR build label Dec 7, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Dec 7, 2024

@lsiepel : are you waiting for a user feedback or can we merge?

@lolodomo lolodomo removed the rebuild Triggers Jenkins PR build label Dec 7, 2024
@lsiepel
Copy link
Contributor Author

lsiepel commented Dec 7, 2024

@lsiepel : are you waiting for a user feedback or can we merge?

Please merge.

@lolodomo
Copy link
Contributor

lolodomo commented Dec 7, 2024

It looks like we have a problem with Jenkins:

image

@lolodomo lolodomo merged commit 37d910d into openhab:main Dec 7, 2024
4 of 5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Dec 7, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Dec 7, 2024

@wborn @kaikreuzer for information about Jenkins problem.

@lsiepel lsiepel deleted the dsmr-catch-ise branch December 7, 2024 16:05
@kaikreuzer
Copy link
Member

@lolodomo I guess this was an automatic patch deployment - at least the warning has gone and the builds seem to work well. Let me know if you still see any issue there.

@wborn
Copy link
Member

wborn commented Dec 7, 2024

Hello, I did have to restart Jenkins to get the builds working again.
Then after a while the shutdown message showed again, so I restarted it again. 😐

@jlaur jlaur changed the title [dsmr] Fix IllegalStateException in rfc2217 connector [dsmr] Fix IllegalStateException in rfc2217 connector Dec 8, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dsmr] Exceptions in rfc2217 connector brings down the bridge until manual action is made to reload it
4 participants