Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wiz] Enable addon finder support #17856

Merged
merged 2 commits into from
Dec 8, 2024
Merged

[wiz] Enable addon finder support #17856

merged 2 commits into from
Dec 8, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 6, 2024 •
edited
Loading

Closes #17847

@ccutrer ccutrer added the enhancement An enhancement or new feature for an existing add-on label Dec 6, 2024
@ccutrer
[wiz] Enable addon finder support
8116811 
Just use a dummy IP and Mac; we're "not" registering, so it doesn't
really matter

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer mentioned this pull request Dec 6, 2024
Merged
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 6, 2024

Depends on openhab/openhab-core#4477

@ccutrer ccutrer added the awaiting other PR Depends on another PR label Dec 6, 2024
andrewfg
andrewfg approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

bundles/org.openhab.binding.wiz/src/main/resources/OH-INF/addon/addon.xml Show resolved Hide resolved
@ccutrer
spotless
e84c14b 
Signed-off-by: Cody Cutrer <cody@cutrer.us>
@wborn wborn removed the awaiting other PR Depends on another PR label Dec 8, 2024
wborn
wborn approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 4a4f586 into openhab:main Dec 8, 2024
5 checks passed
@wborn wborn added this to the 4.3 milestone Dec 8, 2024
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Dec 8, 2024
@ccutrer ccutrer deleted the wiz-addon-finder branch December 10, 2024 20:04
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@ccutrer @matchews
[wiz] Enable addon finder support (openhab#17856)
0a263cf 
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@andrewfg andrewfg andrewfg approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[wiz] Support suggested addons
4 participants
@ccutrer @andrewfg @wborn @jlaur