Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[freeboxos] Add missing thing actions for active player #17877

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[freeboxos] Add missing thing actions for active player #17877

merged 1 commit into from
Dec 11, 2024

Conversation

lolodomo
Copy link
Contributor

Fix #17874

@lolodomo
[freeboxos] Add missing thing actions for active player
0447f83 
Fix openhab#17874

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Dec 10, 2024
@lolodomo lolodomo requested a review from clinique as a code owner December 10, 2024 17:07
@lolodomo
Copy link
Contributor Author

The available actions for a Freebox Revolution Player thing with this fix:

image

Before this fix:

394052342-4deca89e-bf95-4365-a01e-75b2a21ae33a

clinique
clinique approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

lsiepel
lsiepel approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 2a58b8e into openhab:main Dec 11, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Dec 11, 2024
@lolodomo lolodomo deleted the freeboxos_actions branch December 11, 2024 19:42
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@lolodomo @matchews
[freeboxos] Add missing thing actions for active player (openhab#17877)
18869c6 
Fix openhab#17874

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[freeboxos] Missing thing actions for Freebox Revolution Player
3 participants
@lolodomo @clinique @lsiepel