[mybmw] Fix hcaptchatoken issue (#17862) #17896
Conversation
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
...ng.mybmw/src/main/java/org/openhab/binding/mybmw/internal/console/MyBMWCommandExtension.java
Outdated
Show resolved
Hide resolved
|
I'm sorry @martingrassl the code freeze was today, not sunday, my bad. So this will not be available in 4.3.x until the first patch release. (when merged) |
| <parameter name="hcaptchatoken" type="text" required="true"> | ||
| <label>Captcha-Token</label> | ||
| <description>Captcha-Token for login (see https://bimmer-connected.readthedocs.io/en/stable/captcha.html)</description> | ||
| <context>hcaptchatoken</context> |
There was a problem hiding this comment.
Is this a known context? This is used in the UI, but I don’t know about this value.
There was a problem hiding this comment.
The Captcha token was introduced recently by BMW and now the binding is not working anymore. It was the easiest solution to add the param into the bridge config
There was a problem hiding this comment.
Yes, but I think the context field is not required and does not do anything. The valueis not a known value for OH.
There was a problem hiding this comment.
Ok I just copied it from the password configuration
There was a problem hiding this comment.
Indeed, but password is a known context. When the parameter has a password context, the field content will be hidden by default. If you want this token to be hidden, you can equally set it to context password, but I don’t think that’s needed here.
| @@ -14,6 +14,11 @@ | |||
| <description>MyBMW Password</description> | |||
| <context>password</context> | |||
| </parameter> | |||
| <parameter name="hcaptchatoken" type="text" required="true"> | |||
| <label>Captcha-Token</label> | |||
| <description>Captcha-Token for login (see https://bimmer-connected.readthedocs.io/en/stable/captcha.html)</description> | |||
There was a problem hiding this comment.
Maybe make it more explicit you need to get the token through an external service.
There was a problem hiding this comment.
I want to add a documentation. Was just in a hurry because of the code freeze
…nding/mybmw/internal/console/MyBMWCommandExtension.java Co-authored-by: Mark Herwege <mherwege@users.noreply.github.com> Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Thanks a lot! It is running in my local for one day without issue. I'm just wondering if I have to increment the thing versions although no channel was changed... |
Why do you think it should be increased? Without update instructions/changed channels there is no point. |
...ng.mybmw/src/main/java/org/openhab/binding/mybmw/internal/console/MyBMWCommandExtension.java
Outdated
Show resolved
Hide resolved
holgerfriedrich
added
rebuild
|
@martingrassl FYI we are considering to possibly include this in 4.3. |
@holgerfriedrich wow that would really be great. This PR can't break anything as anyhow the binding is not working right now. The users are desperately waiting for a fix and alternatively I would have to provide the binding by a jar file... thank you very much! |
kaikreuzer
changed the title
|
Thanks @martingrassl, so let's merge this as a last minute fix, so that the binding is working in the 4.3 release! |
kaikreuzer
added
the
bug
* [mybmw] add stop charging command * [mybmw] fix hcaptcha issue (openhab#17862) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
* [mybmw] add stop charging command * [mybmw] fix hcaptcha issue (openhab#17862) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
this PR fixes the issue with the new authentication mechanism in the myBMW API thanks to the great work of bimmer_connected.