Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broadlinkthermostat] Fix binding name #17909

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 15, 2024

With the new broadlink binding, we now have two bindings with the same name:

image

See also https://community.openhab.org/t/broadlink-binding-4-1-0-4-3-0/154734/151

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/broadlink-binding-4-1-0-4-3-0/154734/158

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 2c9947c into openhab:main Dec 16, 2024
5 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 16, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Dec 16, 2024

Can be backported as soon as 4.3.x branch has been created.

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Dec 16, 2024
@jlaur jlaur deleted the broadlinkthermostat-name branch December 17, 2024 05:53
lsiepel pushed a commit that referenced this pull request Dec 18, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Dec 18, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@jlaur jlaur mentioned this pull request Jan 5, 2025
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants