[bondhome] Catch null host exception in discovery service #17924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
bug
ccutrer
approved these changes
Dec 18, 2024
|
Thanks for this fix. I've seen this error in my log occasionally, but has never caused issues controlling my device, so have just prioritized other fixes above it. |
lsiepel
pushed a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lsiepel
added
the
patch
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon upgrading to OH-4.3.0, I am seeing this error at startup or anytime the bond bridge is disabled and re-enabled. The issue appears to be a race condition where the discovery service attempts to start calling request() before bridgeHandler.getBridgeIpAddress() can provide the IP address of the bridge. By catching the IllegalArgumentException , the service will continue and is able to discover devices in subsequent scans.