-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Fix components with an empty name #17933
[mqtt.homeassistant] Fix components with an empty name #17933
Conversation
As opposed to null name. In either case, it's not usable, and we need to use our fallbacks. Signed-off-by: Cody Cutrer <cody@cutrer.us>
org.openhab.binding.mqtt.homeassistant-5.0.0-SNAPSHOT.jar.zip |
@danielstosch: simply replacing the file won't actually run it. The most reliable way I've found is to open openhab console In theory you could just drop it in to |
@ccutrer , it is working now :) |
@ccutrer, it seems working for me as well. Thank you for the prompt fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
This should be backported to 4.3, since it breaks existing users upgrading from 4.2 |
As opposed to null name. In either case, it's not usable, and we need to use our fallbacks. Signed-off-by: Cody Cutrer <cody@cutrer.us>
I've just tested version 4.3.1 and I got the following error on all my zigbee2mqtt lamps:
I guess the null check should also be added on line 307 in AbstractComponent.java. |
Sigh. Two steps forward, one step back. @TheNetStriker: can you post your discovery JSON, so I can add a test for it? I'll get a PR up in the next day or two. |
@ccutrer Sure, here is my discovery JSON with all the zigbee2mqtt things:
|
Oops. Maybe I should have been more clear. I'm looking for the JSON in MQTT at homeassistant/+/+/+/config, not the openHAB inbox JSON. You can use something like MQTT Explorer to find it, or the configuration for a channel on a thing that has actually been added to openHAB has it cached. |
@ccutrer Ok, I was able to export the MQTT config JSON topics via the mosquitto_sub command line. There are also some esphome devices in there. Maybe this also helps for the tests. The output is to big to post here, so I uploaded it to pastebin: https://pastebin.com/Ne5uiKFn |
As opposed to null name. In either case, it's not usable, and we need to use our fallbacks. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Re-fixes openhab#15427, regressed from openhab#17933 Signed-off-by: Cody Cutrer <cody@cutrer.us>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
As opposed to null name. In either case, it's not usable, and we need to use our fallbacks. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Re-fixes openhab#15427, regressed from openhab#17933 Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
As opposed to null name. In either case, it's not usable, and we need to use our fallbacks.
Fixes #17920