[knx] Allow color temperatures specified in mired #18004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows other bindings or scripts to send commands which specify the color temperature in mired. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added
the
enhancement
andrewfg
reviewed
Dec 30, 2024
...org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/dpt/ValueEncoder.java
Show resolved
Hide resolved
andrewfg
reviewed
Dec 30, 2024
| // unit for 7.600 is K; special handling for color temperature: make sure °C and mired work as well | ||
| assertEquals("3273.15", ValueEncoder.encode(new QuantityType<>("3000 °C"), "7.600")); | ||
| assertEquals("4000", ValueEncoder.encode(new QuantityType<>("250 mired"), "7.600")); | ||
| assertEquals("4000", ValueEncoder.encode(new QuantityType<>("250 mirek"), "7.600")); |
There was a problem hiding this comment.
Not strictly necessary to test it (the aliases are anyway tested in core) .. but for completeness MK⁻¹ is another possible alias.
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Jan 3, 2025
This allows other bindings or scripts to send commands which specify the color temperature in mired. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-3-milestone-discussion/158139/131 |
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
This allows other bindings or scripts to send commands which specify the color temperature in mired. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other bindings or scripts to send commands which specify the color temperature in mired.