[insteon] Fix x10 device message handling #18031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/insteon-x10-setup-broke-after-update-to-4-3-1/161382/2 |
jlaur
added
bug
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
jsetton
force-pushed
the
insteon-x10-fix
branch
from
95c2a73 to
09c234a
Compare
|
These fixes have been fully tested on the legacy and new implementation as per the community thread linked above. |
lsiepel
removed
the
additional testing preferred
jlaur
pushed a commit
that referenced
this pull request
Jan 4, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
GearrelW
pushed a commit
to GearrelW/openhab-addons
that referenced
this pull request
Jan 12, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the message handling for x10 device.
This includes 3 bug fixes:
X10Addresshouse code is incorrect when instantiated with a message address byte. This is affecting the legacy implementation as well preventing incoming X10 messages from being processed by the binding.X10Addressfailed to instantiate with a string based X10 address including a unit code with more than 1 digit (e.g.L.15). This is affecting the legacy implementation which rely on a string based address being parsed, opposed to the new one that has the house and unit configuration already separated.This change should be back ported as the X10 integration is currently broken.