[insteon] Fix legacy all link broadcast message not processed #18049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
jsetton
force-pushed
the
insteon-legacy-bcast-fix
branch
from
bbc5f1c to
f50c95c
Compare
lsiepel
approved these changes
Jan 6, 2025
lsiepel
pushed a commit
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
lsiepel
added
the
patch
GearrelW
pushed a commit
to GearrelW/openhab-addons
that referenced
this pull request
Jan 12, 2025
…b#18049) Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
…b#18049) Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug introduced in the legacy implementation where incoming all link broadcast messages aren't being processed. Previously, the
Msgclass methodisBroadcastincluded both broadcast message types (standard and all-link broadcasts). After the rewrite, that method was decoupled only including the standard type, while a new methodisAllLinkBroadcastwas added to check for the other type. For reference, Insteon message requests (outgoing) can only be of direct or all-link broadcast types.This fix should be back ported as physical button press events aren't processed by the legacy implementation delaying the state update of some of the channels until the next binding poll. I did run a successful test in my environment of this change.