[jsscripting] Use OSGi-ified GraalVM dependencies #18053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
force-pushed
the
jsscripting-osgi
branch
2 times, most recently
from
9d54020 to
3629950
Compare
Signed-off-by: Florian Hotze <dev@florianhotze.com>
…endency Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
jsscripting-osgi
branch
from
3629950 to
2d43a6d
Compare
Signed-off-by: Florian Hotze <dev@florianhotze.com>
…ndency Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
jsscripting-osgi
branch
from
fcc3add to
4098a58
Compare
florian-h05
changed the title
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
changed the title
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
|
Question: is there a reason you didn't OSGi-ify the polyglot dependency? That also seems like it's going to be shared with the pythonscripting add-on. |
|
Yeah, I didn’t do this because I couldn’t get if work and I think it might not be able to work at all. Both the Polyglot and the Truffle API dependencies use the Java ServiceLoader to load the available engines and languages, which depend on the actual language you use. OSGi-ifying those two dependencies would require to be able to modify the service loading bevahiour of those two depending on the bundle requiring them. I googled a bit (I am no OSGi expert either) and everywhere it was recommended to build a fat JAR including those two deps. |
florian-h05
added
the
enhancement
|
@florian-h05 works for the pythonscripting binding too |
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
* [jsscripting] Use OSGI-ified org.graalvm.sdk:* dependencies Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18054 by using a OSGi-ified Truffle Runtime, which is loaded only once.
It also reduces the add-on size from 34 MB to 16 MB: Truffle ICU4j was pretty big and now is provided as OSGi bundle and hence not bundled with the add-on anymore.
GraalVM Polyglot and Truffle API dependencies cannot be provided as OSGi bundles, because those use the Java ServiceLoader to load the available polyglot and truffle language implementations, which depend on on the individual add-on, and we cannot configure the service loading for those if they are shared OSGi bundles.