[roku] Add End Time and Media Progress channels #18059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
mlobstein
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jlaur
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Thanks for the new channels. Can you also regenerate the I18N properties file since new channel types were added? Otherwise LGTM.
...penhab.binding.roku/src/main/java/org/openhab/binding/roku/internal/handler/RokuHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
GearrelW
pushed a commit
to GearrelW/openhab-addons
that referenced
this pull request
Jan 12, 2025
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following read-only channels to the binding similar to the Plex binding :
The values for these channels are calculated from the Elapsed Time and Total Time values provided by the Roku API. Some streaming apps do not provide these values and in that case these channels will display an UNDEF value.