[basicprofiles] Fix division-by-zero error in $DELTA_PERCENT state filter #18089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
added
awaiting other PR
jimtng
force-pushed
the
statefilter-deltapercent-divzero
branch
from
eb982f9 to
d844ddd
Compare
|
rebased and ready |
jimtng
force-pushed
the
statefilter-deltapercent-divzero
branch
from
d844ddd to
9eea794
Compare
|
rebased again to resolve conflicts |
lolodomo
reviewed
Feb 2, 2025
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Show resolved
Hide resolved
.../test/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfileTest.java
Outdated
Show resolved
Hide resolved
andrewfg
requested changes
Feb 2, 2025
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Outdated
Show resolved
Hide resolved
…lter Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
statefilter-deltapercent-divzero
branch
from
9eea794 to
0e07cd4
Compare
|
Rebased + removed duplicate tests |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andrewfg
requested changes
Feb 3, 2025
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Show resolved
Hide resolved
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
lolodomo
approved these changes
Feb 9, 2025
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
…lter (openhab#18089) * [basicprofiles] Fix division-by-zero error in $DELTA_PERCENT state filter * use Optional for acceptedState Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
…lter (openhab#18089) * [basicprofiles] Fix division-by-zero error in $DELTA_PERCENT state filter * use Optional for acceptedState Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jlaur
pushed a commit
that referenced
this pull request
Feb 24, 2025
…lter (#18089) * [basicprofiles] Fix division-by-zero error in $DELTA_PERCENT state filter * use Optional for acceptedState Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
@jimtng - this has now also been cherry-picked into 4.3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also be backported