[huesync] Fix lost api-token when device goes offline #18100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgfeller
force-pushed
the
huesync/issue/18062
branch
from
f1dfb75 to
48daebe
Compare
|
Hi @lsiepel - I've added you as reviewer already, but the fix is far from ready to be merged. But maybe it is easier for you to follow how the fix evolves rather than to review all at once. That way you can also comment at any time if you have concerns. hope you are fine and as always - thanks for your work for the community and especially for your support to me 🙂 |
pgfeller
force-pushed
the
huesync/issue/18062
branch
2 times, most recently
from
c4c5cf6 to
552b178
Compare
pgfeller
changed the title
pgfeller
force-pushed
the
huesync/issue/18062
branch
2 times, most recently
from
bd7e07a to
116e8ce
Compare
pgfeller
force-pushed
the
huesync/issue/18062
branch
from
09d10ea to
47fd98f
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/huesync-patched-version-for-4-3-2-to-address-issue-18062/162197/1 |
pgfeller
force-pushed
the
huesync/issue/18062
branch
from
7223041 to
238a57b
Compare
…ffline Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
force-pushed
the
huesync/issue/18062
branch
from
238a57b to
e4c1906
Compare
…ffline Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
lsiepel
reviewed
Feb 18, 2025
...uesync/src/main/java/org/openhab/binding/huesync/internal/types/HueSyncExceptionHandler.java
Outdated
Show resolved
Hide resolved
…binding/huesync/internal/types/HueSyncExceptionHandler.java Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel
changed the title
lsiepel
pushed a commit
that referenced
this pull request
Feb 18, 2025
* fix(18062): [huesync] Configuration (API Token) lost if device goes offline Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
lsiepel
added
the
patch
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
* fix(18062): [huesync] Configuration (API Token) lost if device goes offline Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Refactoring of connection handling
Refactored exception connection exception handling to provide more information and improve code structure/maintainability. Connection settings are no longer deleted if the device disconnects.