Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[surepetcare] API change pet weight #18105

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[surepetcare] API change pet weight #18105

merged 2 commits into from
Jan 14, 2025

Conversation

HerzScheisse
Copy link
Contributor

  • API seems to be changed at some point... the weight is now in gram not in kilogram anymore

@HerzScheisse
[surepetcare] API change pet weight
042154a 
* API seems to be changed at some point... the weight is now in gram not in kilogram anymore

Signed-off-by: Holger Eisold <github@eisold.family>
@HerzScheisse
Copy link
Contributor Author

surepet_api_change_2
weight entry in the app is in kilogram
surepet_api_change
output in the API json is in gram

@renescherer
Copy link
Contributor

Thanks for the PR @HerzScheisse

@HerzScheisse
Copy link
Contributor Author

Great to see you still here @renescherer :)

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 14, 2025
@jlaur
Fix table formatting
7a57af6 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
jlaur approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 95aaf1d into openhab:main Jan 14, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Jan 14, 2025
jlaur pushed a commit that referenced this pull request Jan 14, 2025
@HerzScheisse @jlaur
[surepetcare] API change pet weight (#18105)
458401b 
* API seems to be changed at some point... the weight is now in gram not in kilogram anymore

Signed-off-by: Holger Eisold <github@eisold.family>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jan 14, 2025
@HerzScheisse
Copy link
Contributor Author

thanks for the fast merge :)
currently also working on some other issues and new device for this binding...

@jlaur
Copy link
Contributor

jlaur commented Jan 14, 2025

currently also working on some other issues and new device for this binding...

Nice to see some new development on this binding! 👍

@HerzScheisse HerzScheisse deleted the surepet_patch branch January 14, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@renescherer renescherer renescherer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HerzScheisse @renescherer @jlaur