[ecobee] Fix setting vacation hold temperatures and ignore unrealistic actual temperature #18113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
|
Do you think this commit can be cherry picked for 4.x? |
jlaur
changed the title
Yes, sure, it looks solid and quite low risk. 👍 Please review the new PR title as I was struggling trying to cram description of the two fixes into one sentence. 😉 |
jlaur
changed the title
mhilbush
changed the title
Haha, yeah, I was struggling with that too. I gave it a shot. |
jlaur
pushed a commit
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Mark Hilbush <mark@hilbush.com>
chingon007
pushed a commit
to chingon007/openhab-addons
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Mark Hilbush <mark@hilbush.com> Signed-off-by: chingon007 <tron81@gmx.de>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Mark Hilbush <mark@hilbush.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
PascalTurbo
pushed a commit
to PascalTurbo/openhab-addons
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Mark Hilbush <mark@hilbush.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18110 and #15042
Signed-off-by: Mark Hilbush mark@hilbush.com