-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[insteon] Use separate pool for long running threads #18147
Conversation
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonBridgeHandler.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/insteon/internal/handler/InsteonLegacyNetworkHandler.java
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonBridgeHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@jsetton : can be backported to 4.3.x with no risk? |
No risk. I have been testing with users on 4.3 actually. |
@lolodomo were you able to backport this change? |
Cherry-picking this PR in 4.3.x branch leads to conflicts:
I aborted. |
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
@lolodomo You can use jsetton@bd3ca77 The conflicts are related to #17922. |
Patched by #18279 |
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
This change adds a separate pool for long running threads.
This should be backported as the binding is unable to successfully download the modem database for some users, preventing the initialization process from completing.