Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Use separate pool for long running threads #18147

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Jan 21, 2025

This change adds a separate pool for long running threads.

This should be backported as the binding is unable to successfully download the modem database for some users, preventing the initialization process from completing.

Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
@jsetton jsetton added the bug An unexpected problem or unintended behavior of an add-on label Jan 21, 2025
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 2474953 into openhab:main Feb 2, 2025
2 checks passed
@lolodomo lolodomo added this to the 5.0 milestone Feb 2, 2025
@jsetton jsetton deleted the insteon-thread-pool branch February 2, 2025 19:21
@lolodomo
Copy link
Contributor

lolodomo commented Feb 2, 2025

@jsetton : can be backported to 4.3.x with no risk?

@jsetton
Copy link
Contributor Author

jsetton commented Feb 2, 2025

No risk. I have been testing with users on 4.3 actually.

@jsetton
Copy link
Contributor Author

jsetton commented Feb 5, 2025

@lolodomo were you able to backport this change?

@lolodomo
Copy link
Contributor

lolodomo commented Feb 8, 2025

Cherry-picking this PR in 4.3.x branch leads to conflicts:

$ git cherry-pick 247495335e7c41e4a0edd753b152ad54d70f27de
Auto-merging bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonLegacyNetworkHandler.java
CONFLICT (content): Merge conflict in bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonLegacyNetworkHandler.java
Auto-merging bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonBridgeHandler.java
CONFLICT (content): Merge conflict in bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonBridgeHandler.java
Auto-merging bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonBaseThingHandler.java
error: could not apply 247495335e... [insteon] Use separate pool for long running threads (#18147)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

I aborted.

chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
jsetton added a commit to jsetton/openhab-addons that referenced this pull request Feb 16, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
@jsetton
Copy link
Contributor Author

jsetton commented Feb 16, 2025

@lolodomo You can use jsetton@bd3ca77

The conflicts are related to #17922.

@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Feb 18, 2025
@lsiepel
Copy link
Contributor

lsiepel commented Feb 18, 2025

Patched by #18279

matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants