Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bluetooth.bluez] Fix NullPointerException #18181

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[bluetooth.bluez] Fix NullPointerException #18181

merged 1 commit into from
Jan 24, 2025

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 24, 2025

Fixes #18180

@jlaur
Fix NullPointerException
33f5e72 
Fixes openhab#18180

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 24, 2025
lsiepel
lsiepel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 29e909e into openhab:main Jan 24, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 24, 2025
@jlaur jlaur deleted the 18180-bluetooth-bluez-npe branch January 24, 2025 22:07
@jlaur
Copy link
Contributor Author

jlaur commented Jan 24, 2025

@lsiepel - thanks for the quick review. I think this would be good to have in 4.3.x as well, WDYT?

@lsiepel
Copy link
Contributor

lsiepel commented Jan 25, 2025

@lsiepel - thanks for the quick review. I think this would be good to have in 4.3.x as well, WDYT?

Yes, please do. I’m about to leave for a ski trip this week so will be AFK. 😀

@jlaur
Copy link
Contributor Author

jlaur commented Jan 25, 2025

I’m about to leave for a ski trip this week

Nice, have a good trip! 🎿

jlaur added a commit that referenced this pull request Jan 25, 2025
@jlaur
Fix NullPointerException (#18181)
37a858c 
Fixes #18180

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jan 25, 2025
jlaur added a commit that referenced this pull request Jan 25, 2025
@jlaur
Fix NullPointerException (#18181)
85555ad 
Fixes #18180

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur mentioned this pull request Jan 25, 2025
Merged
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
@jlaur @chilobo
Fix NullPointerException (openhab#18181)
79196bf 
Fixes openhab#18180

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
PascalTurbo pushed a commit to PascalTurbo/openhab-addons that referenced this pull request Feb 11, 2025
@jlaur
Fix NullPointerException (openhab#18181)
3b29017 
Fixes openhab#18180

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@blafois blafois Awaiting requested review from blafois blafois is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[bluetooth.bluez] NullPointerException in getDBusBlueZCharacteristicByUUID
2 participants
@jlaur @lsiepel