[boschshc] Add support for Door/Window Contact II Plus #18201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-pace
added
the
enhancement
david-pace
force-pushed
the
18162-window-contact-2-plus
branch
from
f30a5fa to
79ddadd
Compare
jlaur
reviewed
Feb 5, 2025
...hshc/src/main/java/org/openhab/binding/boschshc/internal/devices/BoschSHCHandlerFactory.java
Outdated
Show resolved
Hide resolved
...a/org/openhab/binding/boschshc/internal/devices/windowcontact/WindowContact2PlusHandler.java
Outdated
Show resolved
Hide resolved
david-pace
added
additional testing preferred
* add thing type definition and channel type definitions * re-generate i18n properties * add constants for thing type and channel types * implement new vibration sensor service * add handler for Door/Window Contact II Plus * register handler in factory * add unit tests * add documentation * use opportunity to add documentation for developers regarding typical steps to support new things/channels Signed-off-by: David Pace <dev@davidpace.de>
david-pace
force-pushed
the
18162-window-contact-2-plus
branch
from
79ddadd to
603e27a
Compare
jlaur
changed the title
Signed-off-by: David Pace <dev@davidpace.de>
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: David Pace <dev@davidpace.de>
|
@GerdZanker do you have a Door/Window Contact II Plus by any chance so that you could test this with the actual hardware? |
|
I'm sorry, I have only "old" hardware and no devices of the second generation. Therefor I can only test if the new code is still working as before. |
Also update/enhance developer documentation Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: David Pace <dev@davidpace.de>
|
This PR was tested successfully with the actual hardware, see #18162 (comment) The PR is now open for a final review and can be merged from my side 🚀 |
david-pace
removed
additional testing preferred
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
Signed-off-by: David Pace <dev@davidpace.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18162