[haassohnpelletstove] Improve connection handling #18212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of weak wifi signal and automatically reconnect the thing. Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
Signed-off-by: chingon007 <tron81@gmx.de>
chingon007
added
bug
lsiepel
requested changes
Feb 19, 2025
...c/main/java/org/openhab/binding/haassohnpelletstove/internal/HaasSohnpelletstoveHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/haassohnpelletstove/internal/HaasSohnpelletstoveHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/haassohnpelletstove/internal/HaasSohnpelletstoveHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/haassohnpelletstove/internal/HaasSohnpelletstoveHandler.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.haassohnpelletstove/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
lsiepel
changed the title
Signed-off-by: chingon007 <tron81@gmx.de>
|
When the last two comments are addressed we can merge this. As the first 5.0 milestone is close, we might already get this in. |
Signed-off-by: chingon007 <tron81@gmx.de>
Done |
lsiepel
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Thanks for quickly addresssing the comments.
LGTM
edit: for future PR’s please change your sign off message as we have a real name requirement
https://www.openhab.org/docs/developer/contributing.html#sign-your-work
Signed-off-by: chingon007 tron81@gmx.de
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
* Adding a Reconnect Rate to improve connectivity for the thing in case of weak wifi signal and automatically reconnect the thing. Signed-off-by: chingon007 <tron81@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement:
Refactored binding for easier maintenance. Delted obsolete code and made thing more robust to automatically reconnect in case of network problems.