-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Use a single channel for all scenes on a device #18262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It accepts either object ID, or scene name (assuming the latter doesn't conflict with the former). Command descriptions are fully populated. You also no longer need to deal with sending the payload_on. Merging components is refactored slightly, now that multiple component types do it. Signed-off-by: Cody Cutrer <cody@cutrer.us>
lsiepel
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
I guess this would warrant for an upgrade notice in the distro, could you create a PR?
ccutrer
added a commit
to ccutrer/openhab-distro
that referenced
this pull request
Feb 18, 2025
See openhab/openhab-addons#18262 Signed-off-by: Cody Cutrer <cody@cutrer.us>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
holgerfriedrich
pushed a commit
to openhab/openhab-distro
that referenced
this pull request
Feb 18, 2025
See openhab/openhab-addons#18262 Signed-off-by: Cody Cutrer <cody@cutrer.us>
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
…penhab#18262) It accepts either object ID, or scene name (assuming the latter doesn't conflict with the former). Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
An enhancement or new feature for an existing add-on
(potentially) not backward compatible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It accepts either object ID, or scene name (assuming the latter doesn't conflict with the former). Command descriptions are fully populated. You also no longer need to deal with sending the payload_on.
Merging components is refactored slightly, now that multiple component types do it.
Closes #18259