Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Truncate debug log files when starting monitor #18295

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Feb 19, 2025

This changes the behavior on how monitor files are cleared when starting monitor. For single device monitoring, the file will now be truncated (or created if not present) instead of being deleted. This will allow the ability to tail the given log file prior to its first event message getting logged. For all devices monitoring, the files matching the message events file prefix will continue to be deleted as previously.

Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
@jsetton jsetton added the enhancement An enhancement or new feature for an existing add-on label Feb 19, 2025
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/how-to-define-an-unknown-insteon-device-ezx10rf-to-oh4/162041/71

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit e5ab744 into openhab:main Feb 19, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 19, 2025
@jsetton jsetton deleted the insteon-debug-log-truncate branch February 19, 2025 20:40
matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants