[rrd4j] Fix restore on startup #18308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
lsiepel
added
bug
kaikreuzer
approved these changes
Feb 22, 2025
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18303
With openhab/openhab-core#4463, the restoreOnStartup strategy not only restores the last state, but also the last state update, last state change and previous state. To achieve that, a default method was implemented that queries the DB and searches backwards for the last state change. That query does not have a start date, rather looks as far as it needs.
RRD4J does not allow a query with no start date. Therefore the default method is overriden in this PR to limit how far back in the history the query will look.
In general, mapdb is the more efficient storage to restore values on startup, allowing to retrieve all values for all item types.
@kaikreuzer FYI