Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected some missing / outdated copyright notices #2144

Merged

Conversation

martinvw
Copy link
Member

Signed-off-by: Martin van Wingerden martinvw@mtin.nl

Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
@mention-bot
Copy link

@martinvw, thanks for your PR! By analyzing the history of the files in this pull request, we identified @davidgraeff to be a potential reviewer.

@martinvw
Copy link
Member Author

Thanks @mention-bot I think @kaikreuzer would also do ;-)

@kaikreuzer
Copy link
Member

Interesting, I thought we had already covered them all through an earlier PR...
@svilenvul I had this effect a few times in the past: The SAT failed on stuff that had already passed on earlier occasions (and which clearly shouldn't have passed before). Any idea why this could be the case?

@kaikreuzer kaikreuzer merged commit 3ba1b3c into openhab:master Apr 10, 2017
@martinvw martinvw deleted the feature/missing-outdated-copyright-notices branch April 10, 2017 16:50
@martinvw
Copy link
Member Author

I think that in this case it's caused by PR's being merged containing incorrect headers.

@davidgraeff
Copy link
Member

Sry for the milight add-on being a big part of this PR. The original milight PR was made in 2016 and only accepted in 2017, so the reviewers had already done the boring checks (like checking the copyright headers) and concentrated on the logic in the later review process I guess.

tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
@kaikreuzer kaikreuzer modified the milestone: 2.1 Jun 23, 2017
qvistgaard pushed a commit to qvistgaard/openhab2-addons that referenced this pull request Jun 30, 2017
Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Jan 25, 2021
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cpmeister pushed a commit that referenced this pull request Feb 9, 2021
#9985)

* [hue] implement PR #2144 in openhab.core
* [hue] add binding configuration parameter; return long

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Feb 10, 2021
openhab#9985)

* [hue] implement PR openhab#2144 in openhab.core
* [hue] add binding configuration parameter; return long

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
openhab#9985)

* [hue] implement PR openhab#2144 in openhab.core
* [hue] add binding configuration parameter; return long

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
openhab#9985)

* [hue] implement PR openhab#2144 in openhab.core
* [hue] add binding configuration parameter; return long

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
…e Inbox (openhab#2144)

* [discovery.upnp] delay removing devices from Inbox

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
openhab#9985)

* [hue] implement PR openhab#2144 in openhab.core
* [hue] add binding configuration parameter; return long

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants