Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported and renamed a few packages in the Netatmo binding. #2651

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

VelinYordanov
Copy link

@martinvw martinvw requested a review from clinique August 30, 2017 13:51
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the point to export o.o.b.netatmo.handler.station and thermostat

See openhab/static-code-analysis#100

Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
@VelinYordanov
Copy link
Author

Thanks for the review. I updated the pull request.

Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@martinvw martinvw closed this Aug 30, 2017
@martinvw martinvw reopened this Aug 30, 2017
@martinvw
Copy link
Member

@kaikreuzer are you aware of troubles with: https://openhab.jfrog.io/openhab/eclipse-smarthome-stable/content.xml.xz we have failing builds because of timeouts with them?

@kaikreuzer
Copy link
Member

No, not aware of anything. But also just saw https://community.openhab.org/t/snapshot-build-1027-oh2-2-hangs-on-startup/33744/9. I'd hope that it is a temporary issue at JFrog...

@martinvw martinvw closed this Aug 30, 2017
@martinvw martinvw reopened this Aug 30, 2017
@martinvw martinvw closed this Aug 30, 2017
@martinvw martinvw reopened this Aug 30, 2017
@martinvw martinvw merged commit 771d840 into openhab:master Aug 30, 2017
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
hillmanr pushed a commit to hillmanr/openhab2-addons-pollytts that referenced this pull request Dec 6, 2017
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants