-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported and renamed a few packages in the Netatmo binding. #2651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the point to export o.o.b.netatmo.handler.station and thermostat
See openhab/static-code-analysis#100 Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
4e2465b
to
064ea7e
Compare
Thanks for the review. I updated the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me
@kaikreuzer are you aware of troubles with: https://openhab.jfrog.io/openhab/eclipse-smarthome-stable/content.xml.xz we have failing builds because of timeouts with them? |
No, not aware of anything. But also just saw https://community.openhab.org/t/snapshot-build-1027-oh2-2-hangs-on-startup/33744/9. I'd hope that it is a temporary issue at JFrog... |
…2651) See openhab/static-code-analysis#100 Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
…2651) See openhab/static-code-analysis#100 Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
…2651) See openhab/static-code-analysis#100 Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
See openhab/static-code-analysis#100
Signed-off-by: VelinYordanov velin.iordanov@gmail.com