Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to Mockito 2 #3238

Merged
merged 1 commit into from
Feb 13, 2018
Merged

switched to Mockito 2 #3238

merged 1 commit into from
Feb 13, 2018

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

@kaikreuzer kaikreuzer merged commit 7d73ba7 into openhab:master Feb 13, 2018
@kaikreuzer kaikreuzer deleted the mockito branch February 13, 2018 21:46
@wborn
Copy link
Member

wborn commented Feb 14, 2018

@kaikreuzer it looks like the tests in org.openhab.binding.feed.test have become unstable due to this PR. See also the Travis PR builds.

According to the log file of my local master build it now fails due to unresolved dependencies.

@kaikreuzer
Copy link
Member Author

@wborn They had failed quite often in the past already and even now they are not broken, but appear to be fragile. At least in the official build, they were successful: https://openhab.ci.cloudbees.com/job/openHAB2-Bundles/286/

According to the log file of my local master build it now fails due to unresolved dependencies.

They should pass in Maven, if you rebase your branch on the latest master.
If you run it from the IDE: Yes, the launch launch config probably needs to be adapted to the new target platform.

If the failing test is annoying, feel free to create a PR to temporarily ignore it in the execution.

smf666 pushed a commit to smf666/openhab2-addons that referenced this pull request Feb 18, 2018
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants