Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windcentrale] update millId #4197

Closed
wants to merge 1 commit into from

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Nov 4, 2018

MolenID updated according config xml

<molen>
<id>191</id>
<parkid>31</parkid>
<name>De Boerenzwaluw</name>

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

MolenID updated according config xml
<molen>
<id>191</id>
<parkid>31</parkid>
<name>De Boerenzwaluw</name>

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@wborn
Copy link
Member

wborn commented Nov 4, 2018

Thanks! Can you also update the binding documentation?

@@ -36,7 +36,7 @@
<option value="121">De Trouwe Wachter</option>
<option value="131">De Blauwe Reiger</option>
<option value="141">De Vier Winden</option>
<option value="201">De Boerenzwaluw</option>
<option value="191">De Boerenzwaluw</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get any data when I use the new ID whereas the old one does return data.

You can easily check it in your browser by opening

Existing ID: https://zep-api.windcentrale.nl/production/201/live?ignoreLoadingBar=true

New ID: https://zep-api.windcentrale.nl/production/191/live?ignoreLoadingBar=true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. I noticed the discrepancy while reviewing
https://zep-api.windcentrale.nl/app/config?p=a
which strangely has 191 as the millId instead of 201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants