Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap some features #5701

Merged
merged 3 commits into from
Jun 8, 2019
Merged

unwrap some features #5701

merged 3 commits into from
Jun 8, 2019

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 7, 2019

remove unnecessary wrappings and replace wrappings with apache service-mix

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K added the infrastructure Build system and Karaf related issues and PRs label Jun 7, 2019
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Copy link
Member

@davidgraeff davidgraeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@davidgraeff
Copy link
Member

Ups, Netamo doesn't run through anymore with travis

@J-N-K
Copy link
Member Author

J-N-K commented Jun 7, 2019

Interesting. It ran through locally. And it looks for 2.2.0<x<3.0.0 which should cover 2.3.0. will have a Look. Unfortunately 2.3 is not available in servicemix, only 2.2 and some later version, IIRC.

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K
Copy link
Member Author

J-N-K commented Jun 8, 2019

I reverted the netatmo change for now. It worky with the wrapped bundle in the osgiify-branch. I don't understand why "wrap" works for okio but not for okhttp.

Copy link
Member

@davidgraeff davidgraeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@davidgraeff davidgraeff merged commit 345f2e9 into openhab:master Jun 8, 2019
@J-N-K J-N-K deleted the cleanup-features branch June 8, 2019 10:40
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-cloud-connector-not-working-anymore-after-snapshot-1607/76308/8

Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
* unwrap some features

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
@wborn wborn added this to the 2.5 milestone Jul 30, 2019
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
* unwrap some features

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
* unwrap some features

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants