Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xmppclient] remove wrapping and force dependency install #5707

Merged
merged 1 commit into from
Jun 12, 2019
Merged

[xmppclient] remove wrapping and force dependency install #5707

merged 1 commit into from
Jun 12, 2019

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 8, 2019

Fixes #5473

  • Replaced wrapped xpp3 with servicemix
  • The missing dependencies are not properly referenced by the bundles that need them at runtime. Therefore we have to force their installation.

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

@J-N-K
remove wrapping and force dependency install
9f34773 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on infrastructure Build system and Karaf related issues and PRs labels Jun 8, 2019
@J-N-K
Copy link
Member Author

J-N-K commented Jun 8, 2019

Why is Jenkins now always failing with GC Overhead or Timeouts?

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/preparation-for-2-5m2/75738/20

@kaikreuzer
Copy link
Member

Why is Jenkins now always failing with GC Overhead or Timeouts?

Don't know, but as Travis succeeded, let's call it ready :-)

kaikreuzer
kaikreuzer approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 504b52a into openhab:master Jun 12, 2019
@J-N-K J-N-K deleted the fix-xmpp branch June 16, 2019 08:25
@J-N-K J-N-K mentioned this pull request Jun 18, 2019
Merged
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@J-N-K @Pshatsillo
remove wrapping and force dependency install (openhab#5707)
52dced4 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
@wborn wborn added this to the 2.5 milestone Jul 30, 2019
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@J-N-K @ne0h
remove wrapping and force dependency install (openhab#5707)
fb7b842 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
@wborn wborn removed the bug An unexpected problem or unintended behavior of an add-on label Dec 8, 2019
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@J-N-K @tmrobert8
remove wrapping and force dependency install (openhab#5707)
17f81f0 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

[xmppclient] Not all dependencies are automatically resolved
4 participants
@J-N-K @openhab-bot @kaikreuzer @wborn