[hueemulation] Fix warnings/stacktraces at startup #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly annotates optional references with nullable to fix NPEs * Reworked HueEmulationConfigWithRuntime.startNow to prevent IllegalStateException Fixes openhab#5622 Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
reviewed
Jun 10, 2019
| @@ -201,10 +201,11 @@ public void handleEvent(@Nullable Event event) { | |||
| initParams.put("com.sun.jersey.api.json.POJOMappingFeature", "false"); | |||
| initParams.put(ServletProperties.PROVIDER_WEB_APP, "false"); | |||
| httpService.registerServlet(RESTAPI_PATH, new ServletContainer(resourceConfig), initParams, null); | |||
| if (discovery == null) { | |||
| UpnpServer localDiscovery = discovery; | |||
There was a problem hiding this comment.
Just a question: Why don't you use
UpnpServer discovery = this.discovery;
IMO this is more clear.
There was a problem hiding this comment.
I'm used to SonarQube telling me declaring local variables that hide fields is a bad practice. ;-)
There was a problem hiding this comment.
This is the rule I'm using on other projects. It sometimes saves you from creating bugs too.
J-N-K
approved these changes
Jun 10, 2019
|
Jenkins fails unrelated |
|
Thanks |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Properly annotates optional references with nullable to fix NPEs * Reworked HueEmulationConfigWithRuntime.startNow to prevent IllegalStateException Fixes openhab#5622 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Properly annotates optional references with nullable to fix NPEs * Reworked HueEmulationConfigWithRuntime.startNow to prevent IllegalStateException Fixes openhab#5622 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Maximilian Hess <mail@ne0h.de>
tmrobert8
pushed a commit
to tmrobert8/openhab-addons
that referenced
this pull request
Jan 21, 2020
* Properly annotates optional references with nullable to fix NPEs * Reworked HueEmulationConfigWithRuntime.startNow to prevent IllegalStateException Fixes openhab#5622 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5622
This fixes all warning/stacktrace noise from this add-on when using the Demo.