[tplinksmarthome] Added support for power outlets HS107, HS300, KP200, KP400 #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilbrand
added
the
enhancement
… and KP400 Closes openhab#5051 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Hilbrand
force-pushed
the
tplinksmarthome-outlet
branch
from
2219525
to
f3f642d
Compare
martinvw
reviewed
Jun 14, 2019
.../main/java/org/openhab/binding/tplinksmarthome/internal/TPLinkSmartHomeDiscoveryService.java
Show resolved
Hide resolved
bundles/org.openhab.binding.tplinksmarthome/src/main/resources/ESH-INF/thing/HS300.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.tplinksmarthome/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
.../src/test/java/org/openhab/binding/tplinksmarthome/internal/device/PowerStripDeviceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
martinvw
approved these changes
Jun 14, 2019
cweitkamp
approved these changes
Jun 27, 2019
| @@ -103,7 +103,7 @@ private HasErrorResponse handleDecimalType(String channelID, Connection connecti | |||
| return null; | |||
| } | |||
|
|
|||
| private TransitionLightStateResponse handleColorTemperature(Connection connection, int colorTemperature, | |||
| private @Nullable TransitionLightStateResponse handleColorTemperature(Connection connection, int colorTemperature, | |||
There was a problem hiding this comment.
As the connection property has been moved to the super class SmartHomeDevice can it be removed here - and elsewhere?
There was a problem hiding this comment.
Yes makes sense. I've removed the connection and configuration parameters.
There was a problem hiding this comment.
ok got merged before I could add 😄 (I've create a new pr: #5766)
cweitkamp
reviewed
Jun 27, 2019
| | brightness | Dimmer | Set the brightness of Smart Home device or dimmer. | HS220, KB100, KL110, KL120, LB100, LB110, LB120, LB200 | | ||
| | colorTemperature | Dimmer | Set the color temperature of Smart Home light. | KB130, KL120, KL130, LB120, LB130, LB230 | | ||
| | color | Color | Set the color of the Smart Home light. | KB130, KL130, LB130, LB230 | | ||
| | power | Number | Actual energy usage in Watt. | HS110, HS300, KLxxx, LBxxx | |
There was a problem hiding this comment.
A second question: Why don't you use UoM here. Are there plans to introduce it for this binding.
There was a problem hiding this comment.
I was wondering about that too recently 😄 The original implementation (for HS110) is from before UoM and the others just reuse the code. I was thinking about making them UoM, although it's also a breaking change for the HS110. But I was planning to change it after this pr was being merged.
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 3, 2019
…, KP400 (openhab#5716) Closes openhab#5051 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
…, KP400 (openhab#5716) Closes openhab#5051 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Maximilian Hess <mail@ne0h.de>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Dec 8, 2019
…, KP400 (openhab#5716) Closes openhab#5051 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
tmrobert8
pushed a commit
to tmrobert8/openhab-addons
that referenced
this pull request
Jan 21, 2020
…, KP400 (openhab#5716) Closes openhab#5051 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5051