[globalcache] Update the Item type for Contact Closures to "Switch" #5721
Conversation
The "Contact" item type cannot actually accept commands, so move it to a Switch. The documentation (https://www.openhab.org/addons/bindings/globalcache/) refers to defining these as both Contact and Switch types, but a Contact type is not very useful if you want to change the state of a relay.
|
I haven't tested this in a very long time. It worked at one time, but obviously doesn't anymore. Can you also update the README to make sure there are no references to Contact. |
|
I have updated README.md to reflect this as well. |
|
Thanks. This LGTM. But, I see you missed the Signed-off-by on the commits. Hopefully, this meets the small patch exception and can be merged. |
|
Thanks Mark. Sorry, I have never committed to OpenHab before and am still learning the ropes. I have added a "Signed-off-by" note in the commit description and also installed whatever github "application" that I was pointed to in the docs. What is the next step to get this PR approved? I am using a custom jar file for my own purposes for now, so I am not blocking on this. I suspect other users may want this to work. Is there a way to backport this into 2.4 or can the bindings manifest point to a version that includes this change (2.5)? |
|
One of the maintainer will let us know if this meets the small patch exception, and therefore can be merged without the commit sign-offs. They'll also review the change and do the merge after whcih it will be available in the distribution. As for it being compatible with 2.4, there have been A LOT of changes between 2.4 and now, so I'm not so sure about compatibility. |
…penhab#5721) * Update the Item type for Contact Closures to Switch The "Contact" item type cannot actually accept commands, so move it to a Switch. The documentation (https://www.openhab.org/addons/bindings/globalcache/) refers to defining these as both Contact and Switch types, but a Contact type is not very useful if you want to change the state of a relay. Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/global-cache-binding-gc100-12-and-contact-closure/76946/2 |
…penhab#5721) * Update the Item type for Contact Closures to Switch The "Contact" item type cannot actually accept commands, so move it to a Switch. The documentation (https://www.openhab.org/addons/bindings/globalcache/) refers to defining these as both Contact and Switch types, but a Contact type is not very useful if you want to change the state of a relay. Signed-off-by: Maximilian Hess <mail@ne0h.de>
…penhab#5721) * Update the Item type for Contact Closures to Switch The "Contact" item type cannot actually accept commands, so move it to a Switch. The documentation (https://www.openhab.org/addons/bindings/globalcache/) refers to defining these as both Contact and Switch types, but a Contact type is not very useful if you want to change the state of a relay. Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
The current item type prevents globalcache contact closures from being modified by this module, since it is marked as an item type of "Contact" that can only accept "REFRESH" commands. So, while it can show changes that are done external to this module, all the functionality in the module that makes changes to the contact relays can never be triggered.
The documentation at https://www.openhab.org/addons/bindings/globalcache/ has examples that showcase both Switch and Contact item types. This change will make the Switch use cases actually work.
Today, this is shown in the log:
2019-06-12 22:39:05.386 [DEBUG] [.thing.internal.CommunicationManager] - Received event 'ON' (OnOffType) could not be converted to any type accepted by item 'HomeTheaterCurtainsOpen' (Switch) 2019-06-12 22:39:05.408 [DEBUG] [.thing.internal.CommunicationManager] - Received not accepted type 'OnOffType' for channel 'globalcache:itachCC:000C1E034EF7:cc-m1#c2'
Signed-off-by: Nick Hill knikhilwiz@gmail.com