Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement onError method for websocket connection #5730

Merged
merged 2 commits into from
Jun 16, 2019
Merged

implement onError method for websocket connection #5730

merged 2 commits into from
Jun 16, 2019

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer
implement onError method for websocket connection
af5db62 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer mentioned this pull request Jun 14, 2019
Closed
@wborn
Copy link
Member

wborn commented Jun 14, 2019

The SonyAudioClientSocket class of the sonyaudio binding is probably having the same issue because it also uses annotations but doesn't have a method annotated with @OnWebSocketError. Maybe it can be resolved similarly?

@kaikreuzer
implement onError method for websocket connection
a612654 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

@wborn Good catch. I added it to the SonyAudio binding as well.

wborn
wborn approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit c11517a into openhab:master Jun 16, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@kaikreuzer @Pshatsillo
implement onError method for websocket connection (openhab#5730)
41cbe60 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
@cweitkamp cweitkamp mentioned this pull request Jul 2, 2019
Closed
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 3, 2019
@kaikreuzer @knikhilwiz
implement onError method for websocket connection (openhab#5730)
081aa92 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@wborn wborn added this to the 2.5 milestone Jul 30, 2019
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@kaikreuzer @ne0h
implement onError method for websocket connection (openhab#5730)
37d1561 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@kaikreuzer @tmrobert8
implement onError method for websocket connection (openhab#5730)
03c4f24 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
@kaikreuzer kaikreuzer deleted the kodi branch November 13, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp

@pail23 pail23 Awaiting requested review from pail23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

[kodi] Unable to report throwable to websocket
2 participants
@kaikreuzer @wborn