[konnected] fixes servlet registration #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
martinvw
approved these changes
Jun 26, 2019
cweitkamp
reviewed
Jun 27, 2019
| } catch (KonnectedWebHookFail e) { | ||
| logger.trace("there was an error adding the thing handler to the servlet: {}", e.getMessage()); | ||
| } | ||
| servlet.add(thingHandler); |
There was a problem hiding this comment.
If the registration of the servlet will fail during activation of the factory we will face a NPE here. Should we handle that?
There was a problem hiding this comment.
Valid point. I've added a null check.
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Travis tests were successfulHey @kaikreuzer, |
martinvw
approved these changes
Jun 28, 2019
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 3, 2019
Fixes openhab#5749 Signed-off-by: Kai Kreuzer <kai@openhab.org>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Fixes openhab#5749 Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Maximilian Hess <mail@ne0h.de>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Dec 8, 2019
Fixes openhab#5749 Signed-off-by: Kai Kreuzer <kai@openhab.org>
tmrobert8
pushed a commit
to tmrobert8/openhab-addons
that referenced
this pull request
Jan 21, 2020
Fixes openhab#5749 Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/openhab/openhab2-addons/issues/5749
Signed-off-by: Kai Kreuzer kai@openhab.org