Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further evolution of travis build script #5789

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Further evolution of travis build script #5789

merged 1 commit into from
Jul 2, 2019

Conversation

martinvw
Copy link
Member

@martinvw martinvw commented Jul 2, 2019

Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

@martinvw martinvw requested review from davidgraeff and a team July 2, 2019 06:15
@martinvw martinvw force-pushed the feature/correct-exit-code-correct-commits branch from 3ff9be2 to ecfb512 Compare July 2, 2019 06:23
@martinvw
Further evolution of travis build script
45fadc2 
Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
@martinvw martinvw force-pushed the feature/correct-exit-code-correct-commits branch from ecfb512 to 45fadc2 Compare July 2, 2019 06:24
@davidgraeff davidgraeff added the infrastructure Build system and Karaf related issues and PRs label Jul 2, 2019
@TravisBuddy
Copy link

TravisBuddy commented Jul 2, 2019 •
edited
Loading

Travis tests have failed

Hey @martinvw,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

Expand here 
Build all
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Child module /home/travis/build/openhab/openhab2-addons/bundles/org.gdf.io.azureiothub of /home/travis/build/openhab/openhab2-addons/bundles/pom.xml does not exist @ 
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.openhab.addons.bundles:org.openhab.addons.reactor.bundles:2.5.0-SNAPSHOT (/home/travis/build/openhab/openhab2-addons/bundles/pom.xml) has 1 error
[ERROR]     Child module /home/travis/build/openhab/openhab2-addons/bundles/org.gdf.io.azureiothub of /home/travis/build/openhab/openhab2-addons/bundles/pom.xml does not exist
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

@J-N-K
Copy link
Member

J-N-K commented Jul 2, 2019

Can you make the build fail (so we see that indeed the errorstatus is correctly picked up)? Otherwise LGTM.

@martinvw
Copy link
Member Author

martinvw commented Jul 2, 2019 •
edited
Loading

@davidgraeff do you have any ideas why this logfile does not work anymore for happy messages? We do have successBuildLog enabled so the theory looks good.

@martinvw
Copy link
Member Author

martinvw commented Jul 2, 2019

@J-N-K looks great, let me know when you saw it, then I will remove the commit

@martinvw martinvw force-pushed the feature/correct-exit-code-correct-commits branch from ab4d416 to 45fadc2 Compare July 2, 2019 12:01
@martinvw martinvw merged commit 3ccde8e into openhab:master Jul 2, 2019
@martinvw martinvw deleted the feature/correct-exit-code-correct-commits branch July 2, 2019 12:02
@davidgraeff
Copy link
Member

No I don't have an idea. Maybe we are discarding the log in the travis job? But why do you want the log for happy messages? For showing the SAT findings?

@martinvw
Copy link
Member Author

martinvw commented Jul 2, 2019

No I don't have an idea. Maybe we are discarding the log in the travis job? But why do you want the log for happy messages? For showing the SAT findings?

I don't know you already bootstrapped that ;-)

@davidgraeff
Copy link
Member

Hm. Might be that I just wanted TravisBuddy to report something on success and that I understood successBuildLog as a requirement.

But I'm not entire sold on this tbh. Maybe TravisBuddy should just report failures.

@wborn wborn added this to the 2.5 milestone Jul 30, 2019
sprehn pushed a commit to sprehn/openhab-addons that referenced this pull request Aug 21, 2019
@martinvw @sprehn
Further evolution of travis build script (openhab#5789)
eaa8785 
Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@martinvw @ne0h
Further evolution of travis build script (openhab#5789)
8590170 
Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Dec 8, 2019
@martinvw @Pshatsillo
Further evolution of travis build script (openhab#5789)
5a527a3 
Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@martinvw @tmrobert8
Further evolution of travis build script (openhab#5789)
dd96d55 
Use the commit range given by travis to calculate the changed files (not only new files) and make sure we return the correct exit code

Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
5 participants
@martinvw @TravisBuddy @J-N-K @davidgraeff @wborn