Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openwebnet] OpenWebNet Binding initial contribution, migration from OH1 #6213

Merged
merged 22 commits into from
Aug 20, 2020
Merged

[openwebnet] OpenWebNet Binding initial contribution, migration from OH1 #6213

merged 22 commits into from
Aug 20, 2020

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Oct 13, 2019 •
edited
Loading

OpenWebNet (BTicino/Legrand) Binding

This binding integrates BTicino/Legrand MyHOME home automation systems into openHAB (see #5195).
The binding has to be considered as an enhancement and replacement of the BTicino v1 binding.
WHOs (devices) supported in this first PR:

  • WHO=1 Lighting
  • WHO=13 Gateway Management

Community thread:
https://community.openhab.org/t/bticino-openwebnet-new-openhab2-binding-ready-for-testing/43377/

This contribution is ready for review.

Closes #5195

@mvalla mvalla requested a review from a team as a code owner October 13, 2019 12:33
@mvalla mvalla force-pushed the own-pub branch 2 times, most recently from 07258f7 to d22c584 Compare October 15, 2019 13:32
@TravisBuddy
Copy link

Travis tests were successful

Hey @mvalla,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mvalla mvalla mentioned this pull request Oct 15, 2019
Closed
@Hilbrand Hilbrand added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Oct 16, 2019
@Hilbrand Hilbrand mentioned this pull request Oct 16, 2019
Closed
Hilbrand
Hilbrand reviewed Nov 3, 2019
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I started a review. However when I looked into the library used I have some questions about the library used. I could not find the source code of the library? Also the original library has some other dependencies and I could not find those here. Are they removed? So to continue I think some questions related to the library should be first cleared.

...in/java/org/openhab/binding/openwebnet/internal/discovery/ZigBeeGatewayDiscoveryService.java Outdated Show resolved Hide resolved
...src/main/java/org/openhab/binding/openwebnet/internal/discovery/BusGatewayUpnpDiscovery.java Outdated Show resolved Hide resolved
...enwebnet/src/main/java/org/openhab/binding/openwebnet/internal/OpenWebNetHandlerFactory.java Outdated Show resolved Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java Outdated Show resolved Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java Outdated Show resolved Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved
...src/main/java/org/openhab/binding/openwebnet/internal/discovery/BusGatewayUpnpDiscovery.java Outdated Show resolved Hide resolved
@mvalla mvalla force-pushed the own-pub branch 2 times, most recently from 63d7d30 to ebdf928 Compare November 16, 2019 11:51
@TravisBuddy
Copy link

Travis tests were successful

Hey @mvalla,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
@openhab openhab deleted a comment from TravisBuddy Nov 28, 2019
mvalla added 11 commits August 7, 2020 22:16
@mvalla
@NonNullByDefault
73a61f2 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
Migration to new lib openwebnet-java, @NonNullByDeafault,
f36b231 
 Checkstyle improvements. Updated to 2.5.7-SNAPSHOT

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
new lib name openwebnet4j
397df12 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
remove potential nullpointer exception warnings
eb6208e 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
spotless.apply
7d1fa38 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
review of README.md
08bfd10 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
Changes after complete review by @fwolter
5f168f3 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
use openwebnet4j 0.2.0 to support OPEN and HMAC auth
d4b2d20 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
changes after @Hilbrand 2nd review. Added config objects. Moved to 2.…
6eaa140 
…5.8-SNAPSHOT

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
now using ThingHandlerService
68b156c 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
improved logic for dimmer control to avoid duplicate state updates
c64112f 
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mvalla,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mvalla
Copy link
Contributor Author

mvalla commented Aug 7, 2020

I completed all changes requested by @Hilbrand in his 2nd review and updated the openwebnet4j lib to 0.2.0 to include OPEN/HMAC password support. This PR is again ready from my side. All checks have passed.

@mvalla mvalla requested a review from Hilbrand August 7, 2020 20:29
Hilbrand
Hilbrand approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinvw
Copy link
Member

@Hilbrand if you did a complete review, I would say this has two reviewers. If you feel it needs another round let us know otherwise feel free to merge.

@Hilbrand Hilbrand merged commit 79c11fc into openhab:2.5.x Aug 20, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Aug 20, 2020
@mvalla
Copy link
Contributor Author

mvalla commented Aug 20, 2020

Thanks for merging this pull request. I will advertise it in the relevant thread.

@wborn wborn mentioned this pull request Aug 22, 2020
Merged
taboneclayton pushed a commit to taboneclayton/openhab-addons that referenced this pull request Aug 23, 2020
@mvalla @taboneclayton
[openwebnet] OpenWebNet Binding initial contribution, migration from …
3b6d566 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Clayton Tabone <taboneclayton@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mvalla @andrewfg
[openwebnet] OpenWebNet Binding initial contribution, migration from …
8d3b724 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mvalla @andrewfg
[openwebnet] OpenWebNet Binding initial contribution, migration from …
58fe888 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mvalla @andrewfg
[openwebnet] OpenWebNet Binding initial contribution, migration from …
794466b 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mvalla @andrewfg
[openwebnet] OpenWebNet Binding initial contribution, migration from …
3f21946 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@mvalla @DaanMeijer
[openwebnet] OpenWebNet Binding initial contribution, migration from …
0eb6e2c 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@mvalla @CSchlipp
[openwebnet] OpenWebNet Binding initial contribution, migration from …
af9ace2 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@mvalla @markus7017
[openwebnet] OpenWebNet Binding initial contribution, migration from …
175d62d 
…OH1 (openhab#6213)

Closes openhab#5195

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla deleted the own-pub branch September 24, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@Hilbrand Hilbrand Hilbrand approved these changes

@wborn wborn Awaiting requested review from wborn

Assignees
No one assigned
Labels
cre Coordinated Review Effort new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.

[openwebnet] Add OpenWebNet Binding (with BUS and radio support)
8 participants
@mvalla @TravisBuddy @fwolter @J-N-K @kaikreuzer @martinvw @Hilbrand @wborn