-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsblan] BSB LAN Binding initial contribution #6314
Conversation
Travis tests have failedHey @hypetsch, 2nd BuildExpand here
|
Travis tests were successfulHey @hypetsch, |
1 similar comment
Travis tests were successfulHey @hypetsch, |
Travis tests have failedHey @hypetsch, 2nd BuildExpand here
|
Travis tests have failedHey @hypetsch, 2nd BuildExpand here
|
Travis tests have failedHey @hypetsch, 2nd BuildExpand here
|
Travis tests have failedHey @hypetsch, 2nd BuildExpand here
|
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
… thing status changes Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Travis tests were successfulHey @hypetsch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks really good. These will be my last change requests.
...ab.binding.bsblan/src/main/java/org/openhab/binding/bsblan/internal/api/BsbLanApiCaller.java
Outdated
Show resolved
Hide resolved
...bsblan/src/main/java/org/openhab/binding/bsblan/internal/handler/BsbLanBaseThingHandler.java
Outdated
Show resolved
Hide resolved
...bsblan/src/main/java/org/openhab/binding/bsblan/internal/handler/BsbLanParameterHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at>
Travis tests were successfulHey @hypetsch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now. I forgot to catch this last change in my last pass through the code so you can fix it while we wait for other maintainers to review this.
...ab.binding.bsblan/src/main/java/org/openhab/binding/bsblan/internal/api/BsbLanApiCaller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Schraffl <p.schraffl@gmx.at> Co-Authored-By: cpmeister <mistercpp2000@gmail.com>
Travis tests were successfulHey @hypetsch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, many thanks!
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at> Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at> Signed-off-by: CSchlipp <christian@schlipp.de>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
This binding adds support to interact with a BSB-LAN device which can be used read and write parameters of several heating controlers. More details: https://github.com/fredlcore/bsb_lan
The binding has already been tested by two other users after publishing it in the forum via thread https://community.openhab.org/t/new-binding-for-bsb-lan-device/
The way the binding is working was inspired by the fronius binding.