[shelly] Support for Duo, EM3, DW, Smoke, Addon; new CoAP-based updates; bug fixes #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2020
Travis tests were successfulHey @markus7017, |
markus7017
changed the title
Travis tests were successfulHey @markus7017, |
2 similar comments
Travis tests were successfulHey @markus7017, |
Travis tests were successfulHey @markus7017, |
This was referenced Feb 24, 2020
Travis tests were successfulHey @markus7017, |
4 similar comments
Travis tests were successfulHey @markus7017, |
Travis tests were successfulHey @markus7017, |
Travis tests were successfulHey @markus7017, |
Travis tests were successfulHey @markus7017, |
markus7017
changed the title
Travis tests have failedHey @markus7017, 2nd BuildExpand here |
Travis tests have failedHey @markus7017, 2nd BuildExpand here |
Travis tests were successfulHey @markus7017, |
Travis tests have failedHey @markus7017, 1st BuildExpand here |
Travis tests were successfulHey @markus7017, |
markus7017
changed the title
Travis tests were successfulHey @markus7017, |
1 similar comment
Travis tests were successfulHey @markus7017, |
Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@cpmeister added synchronized to start() |
cpmeister
approved these changes
Apr 18, 2020
|
Just need to make sure that the build is fine then I can merge. |
Signed-off-by: Markus Michels <markus7017@gmail.com>
Travis tests were successfulHey @markus7017, |
|
@cpmeister Well done! I appreciate your help and patience. Thank you. Do you have advises what can be improved ot should be refactored? |
|
One note: The last PR was not mentioned in the release notes. I checked with Kai and he mentioned that maybe tagging the PR as enhancement and as bug might caused this issue. Could you check that? I have a breaking change (channel layout for the RGBW2). Where should that be documented? |
cpmeister
removed
the
bug
As per J-N-K:
|
Which PR was that? |
It should not be there at all - patch releases are supposed to be fully backward compatible! |
|
FTR: I'd suggest not to merge such huge PRs the day before a release - we cannot be sure that it is fully finished (see discussion above) and that it has been thoroughly enough tested by people (see #7416). As we do monthly releases atm, it should always be safer to keep such changes for the next release. |
|
@kaikreuzer I might have gotten carried away and merged this too soon. @markus7017 Please make sure that your future PRs are single purpose. Do not group together different bug fixes and enhancements into a single PR; it can turn a PR into an ever-growing set of changes that become a nightmare to review. The harder something is to review the less likely it will be reviewed/merged in a timely manner. |
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…es; bug fixes (openhab#6985) * Re-checkin based on latest PR review status Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Fixes and enhancements based on PR #6764
Signed-off-by: Markus Michels markus7017@gmail.com