Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exec] Fix missing break in switch #7034

Closed
wants to merge 1 commit into from
Closed

[exec] Fix missing break in switch #7034

wants to merge 1 commit into from

Conversation

9037568
Copy link
Contributor

@9037568 9037568 commented Feb 19, 2020

This fixes a problem discussed in this community thread.

The issue is that a defect was introduced in PR #6819 because a switch block does not contain a break where it ought. This causes the valid OS clause to fall through to the invalid OS clause.

Signed-off-by: 9037568 namraccr@gmail.com

@9037568
Fix missing break in switch
965dae5 
Signed-off-by: 9037568 <namraccr@gmail.com>
@9037568 9037568 requested a review from kgoderis as a code owner February 19, 2020 03:55
@9037568 9037568 added the bug An unexpected problem or unintended behavior of an add-on label Feb 19, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @9037568,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

bjoernbrings
bjoernbrings approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@bjoernbrings bjoernbrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kaikreuzer
Copy link
Member

Fixed with 4c4cb66.

@kaikreuzer kaikreuzer closed this Feb 19, 2020
@kaikreuzer kaikreuzer modified the milestone: 2.5.2 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernbrings bjoernbrings bjoernbrings approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@9037568 @TravisBuddy @kaikreuzer @bjoernbrings