[ojelectronics] Initial contribution

[EvilPingu]

Hi,

this is the initial contribution for ojelectronics binding. First of all i build two things:

• OJCloud: Handles the traffic with the ojelectronics cloud
• Thermostat: Have the (read only) channel for the associated thermostats

OJ Electronics builds floor heating thermostats. Goal of the binding is to support OJ Electronics devices.

EvilPingu

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests have failed

Hey @EvilPingu,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

1st Build

Expand here

Single addon pull request: Building org.openhab.binding.ojelectronics
[ERROR] Failed to execute goal org.commonjava.maven.plugins:directory-maven-plugin:0.3.1:directory-of (directories) on project org.openhab.binding.ojelectronics: Cannot find directory for project: org.openhab.addons:org.openhab.addons.reactor -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

### 2nd Build

Expand here

Single addon pull request: Building org.openhab.binding.ojelectronics
[WARNING] The POM for com.sun.xml.bind:jaxb-core:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.sun.xml.bind:jaxb-impl:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[ERROR] Failed to execute goal org.commonjava.maven.plugins:directory-maven-plugin:0.3.1:directory-of (directories) on project org.openhab.binding.ojelectronics: Cannot find directory for project: org.openhab.addons:org.openhab.addons.reactor -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

[fwolter]

Can you fix the conflicting file and the build errors? I would take a look into it, then.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[EvilPingu]

Can you fix the conflicting file and the build errors? I would take a look into it, then.

Hi @fwolter ,

conflicts are solved now.

EvilPingu

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[fwolter]

Very professional code. I like the usage of Jetty's async API and the lambdas.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.

[TravisBuddy]

Travis tests have failed

Hey @EvilPingu,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests have failed

Hey @EvilPingu,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[EvilPingu]

Very professional code. I like the usage of Jetty's async API and the lambdas.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.

Hi @fwolter,

what are the next steps? How do we get on? Did I miss something?

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[fwolter]

Thanks for the hint. Github doesn't notify when comments are set to resolved.

I found a few minor things I overlooked during the first review. Sorry for that!

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

[fwolter]

Do you want to adopt or comment on this?

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[EvilPingu]

Thanks for the hint. Github doesn't notify when comments are set to resolved.

I found a few minor things I overlooked during the first review. Sorry for that!

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

Hi @fwolter,

i fixed all review things and i also checked target/code-analysis/report.html. It's empty.

@EvilPingu

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[fwolter]

Did you run mvn install? I see 15 warnings:

[EvilPingu]

Did you run mvn install? I see 15 warnings:

I didn't understand this. I'm confused. I make "mvn clean install". No errors, no warning: file:///home/ckit/dev/openhab-2-5-x/git/openhab-addons/target/code-analysis/report.html and file:///home/ckit/dev/openhab-2-5-x/git/openhab-addons/target/summary_report.html

[fwolter]

Did you push your changes? For example RefreshService:56, the field name is still lower case.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[martinvw]

Thanks a lot!

[EvilPingu]

It was a great pleasure for me. I learned a lot. 👍 Thanks for the support.