Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] add console commands to help with troubleshooting #7251

Merged
merged 1 commit into from
Apr 3, 2020
Merged

[insteon] add console commands to help with troubleshooting #7251

merged 1 commit into from
Apr 3, 2020

Conversation

robnielsen
Copy link
Contributor

The commands provide information that is logged by the oh1 binding insteonplm. This is helpful when configuring the binding and supporting people who run into issues.

@robnielsen robnielsen added the enhancement An enhancement or new feature for an existing add-on label Mar 29, 2020
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with merging this but you cannot use singletons to implement this feature.

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
@robnielsen
Copy link
Contributor Author

@cpmeister, I made changes as suggested and commented on one of them. I also cleaned up the README.md file to use 'home' instead of 'local' local was there when the binding auto discovered the network, and it was removed.

@TravisBuddy
Copy link

Travis tests were successful

Hey @robnielsen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@openhab openhab deleted a comment from TravisBuddy Apr 2, 2020
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, If you have tested it and are satisfied then I'll go ahead and merge.

@robnielsen
Copy link
Contributor Author

@cpmeister, yes I have tested it. Thanks!

@cpmeister cpmeister merged commit 552b54b into openhab:2.5.x Apr 3, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 3, 2020
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
…7251)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
…7251)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…7251)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…7251)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants