Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors and changes after importing add-ons in Eclipse #7270

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Fix errors and changes after importing add-ons in Eclipse #7270

merged 4 commits into from
Apr 3, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 1, 2020

  • Add missing Eclipse project/classpath files
  • Fix null analysis errors showing in Eclipse
  • Remove ignored Eclipse .settings files

With these changes there are no unstaged changes and only one error showing in FileTailer (#5442) after importing the add-ons in Eclipse.

@wborn
Fix errors and changes after importing add-ons in Eclipse
1798a90 
* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Fix last remaining error by updating logreader classpath
b529604 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Fix smartmeter classpath
17de514 
Signed-off-by: Wouter Born <github@maindrain.net>
cpmeister
cpmeister approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably should have a second pair of eyes though since this affects a lot of bindings.

@cweitkamp
Copy link
Contributor

cweitkamp commented Apr 3, 2020 •
edited
Loading

One more thing: There is a duplicate project name. The LinuxInput Binding calls itself org.openhab.binding.astro instead of org.openhab.binding.linuxinput.

openhab-addons/bundles/org.openhab.binding.linuxinput/.project

Lines 2 to 4 in 5cef8d3

<projectDescription>
<name>org.openhab.binding.astro</name>
<comment></comment>

Otherwise: Great job!

@wborn
Fix Eclipse linuxinput project name
b52931d 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from t-8ch as a code owner April 3, 2020 10:39
cweitkamp
cweitkamp approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am fine with merging it now. Thanks.

@cweitkamp cweitkamp merged commit 2102cb0 into openhab:2.5.x Apr 3, 2020
@cweitkamp cweitkamp added the infrastructure Build system and Karaf related issues and PRs label Apr 3, 2020
@cweitkamp cweitkamp added this to the 2.5.4 milestone Apr 3, 2020
@wborn wborn deleted the eclipse-fixes branch April 3, 2020 16:25
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@wborn @Hans-Reiner
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
2240442 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@wborn
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
7162443 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@wborn @markus7017
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
2243d3a 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@wborn @LoungeFlyZ
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
abedc21 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@wborn @J-N-K
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
6c9555f 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@wborn @CSchlipp
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
f519013 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
b5d6407 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
3f84707 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
43084d3 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
55f6cb8 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@wborn @DaanMeijer
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
30d6736 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@wborn @markus7017
Fix errors and changes after importing add-ons in Eclipse (openhab#7270)
60ec293 
* Fix errors and changes after importing add-ons in Eclipse

* Add missing Eclipse project/classpath files
* Fix null analysis errors showing in Eclipse
* Remove ignored Eclipse .settings files
* Fix Eclipse linuxinput project name

With these changes there are no unstaged changes and only one error showing in FileTailer (openhab#5442) after importing the add-ons in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@cweitkamp cweitkamp cweitkamp approved these changes

@bjoernbrings bjoernbrings Awaiting requested review from bjoernbrings bjoernbrings is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@Cossey Cossey Awaiting requested review from Cossey Cossey is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff davidgraeff is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@Mr-Eskildsen Mr-Eskildsen Awaiting requested review from Mr-Eskildsen Mr-Eskildsen is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@ollie-dev ollie-dev Awaiting requested review from ollie-dev ollie-dev is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@pavel-gololobov pavel-gololobov Awaiting requested review from pavel-gololobov pavel-gololobov is a code owner

@ppieczul ppieczul Awaiting requested review from ppieczul ppieczul is a code owner

@sjsf sjsf Awaiting requested review from sjsf

@sprehn sprehn Awaiting requested review from sprehn sprehn is a code owner

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

@ZzetT ZzetT Awaiting requested review from ZzetT

@t-8ch t-8ch Awaiting requested review from t-8ch t-8ch is a code owner

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@wborn @cweitkamp @cpmeister